ros-perception / image_common

Common code for working with images in ROS
http://www.ros.org/wiki/image_common
125 stars 220 forks source link

[ADD] std::optional for PublisherOptions #241

Closed wodtko closed 2 years ago

wodtko commented 2 years ago

as described in this https://github.com/ros-perception/image_common/issues/240 PublisherOptions are optional when advertising a topic. By this, the correct advertiseImpl function is called automatically avoiding error messages.

Additionally, advertiseImplWithOptions was renamed to override the respective parent class function instead of creating a new function which also caused error messages due to the missing child class implementation.