ros-perception / image_common

Common code for working with images in ROS
http://www.ros.org/wiki/image_common
125 stars 220 forks source link

Support Modern CMake practices #245

Open RFRIEDM-Trimble opened 2 years ago

RFRIEDM-Trimble commented 2 years ago

As a user of this library in gscam2, I'd like to consume the libraries in image_common with a modern cmake interface, but it's not supplied here.

Here's my proposal:

References:

clydemcqueen commented 2 years ago
  • Bump Minimum cmake for galactic to 3.16.3 and use some of the new features in it for installation

Hi, @RFRIEDM-Trimble -- the CMake versions are defined in REP2000, and would have to be updated there. Looks like the highest version supported by all recommended Galactic platforms is 3.12.2. For Humble it's 3.14.4. https://www.ros.org/reps/rep-2000.html

RFRIEDM-Trimble commented 1 year ago

3.12.2

Got it. I'll bump to 3.12.2 and implement the proposal.