search

ros-perception / image_common

Common code for working with images in ROS
http://www.ros.org/wiki/image_common
125 stars 220 forks source link

Add support for missing ROI and binning fields #254

Closed AndreasR30 closed 1 year ago

AndreasR30 commented 1 year ago

Equivalently to #175 for ROS1, this pull request adds support for binning and roi fields contained in the CameraInfo.msg to the camera_calibration_parsers package for ROS2. So that it is able to write these fields to YAML and to read them from YAML.

To properly use the ROI information I also made this pull request ros2/rviz#864 to Rviz.

AndreasR30 commented 1 year ago

@gbiggs Sorry I used uncrustify with ROS2 config and didn't know that it generates these backup files. Now I use it with --no-backup option. Thank you for drawing attention to these unwanted files.

gbiggs commented 1 year ago

Thanks for the contribution!