search

ros-perception / image_common

Common code for working with images in ROS
http://www.ros.org/wiki/image_common
125 stars 220 forks source link

Lifecycle nodes #258

Open ilidar opened 1 year ago

ilidar commented 1 year ago

Attempt to support rclcpp::LifecycleNode influenced by https://github.com/ros-perception/image_common/pull/167.

devrite commented 1 year ago

Hey,

I also want to see Lifecycle-Nodes supported. Depending on whether people still want to support the old API you could have a look at a branch I started a while ago. I did try to implement an Api for plugins that returns the required node interfaces, which could be skipped if we think we will not extend it beyond node interfaces.

I tried to create additional constructors and templated functions with a different name of the same kind as the old API to still be able support the old API. If this is needed you may take inspiration from that.

https://github.com/devrite/image_common/commits/feature/wip_api_playground