search

ros-perception / image_common

Common code for working with images in ROS
http://www.ros.org/wiki/image_common
124 stars 219 forks source link

add support for lazy subscribers #272

Closed mikeferguson closed 1 year ago

mikeferguson commented 1 year ago

This implements #111 for releases after Iron (where we have connect/disconnect callbacks, per https://github.com/ros2/rmw/issues/330)

mikeferguson commented 1 year ago

Also, not sure if rolling or ros2 is the right branch - they appear to be even with one another right now...

clalancette commented 1 year ago

Also, not sure if rolling or ros2 is the right branch - they appear to be even with one another right now...

Yeah, it is a bit messy now. rolling is the right branch, I retargeted to that.

mikeferguson commented 1 year ago

@clalancette so this can't go into Iron - but can it get merged into rolling now, or does it have to wait until some certain milestone between the Iron and J-turtle release?

clalancette commented 1 year ago

@clalancette so this can't go into Iron - but can it get merged into rolling now, or does it have to wait until some certain milestone between the Iron and J-turtle release?

Rolling is completely open for business!

ahcorde commented 1 year ago

any updates here ?

mikeferguson commented 1 year ago

@ahcorde - this is basically waiting on a review from a maintainer (I've fully implemented the downstream stuff for image_proc and depth_image_proc, so I'm confident this is all we need to add)

ahcorde commented 1 year ago