ros-perception / image_common

Common code for working with images in ROS
http://www.ros.org/wiki/image_common
124 stars 219 forks source link

Merge #276 broke downstream packages #279

Closed jmachowinski closed 1 year ago

jmachowinski commented 1 year ago

Hi, the recent merge of 'Expose callback groups - backport to iron' (https://github.com/ros-perception/image_common/pull/276) just broke donwstream packages (e.g. https://github.com/RobotWebTools/web_video_server) , as

  Subscriber subscribe(
    const std::string & base_topic, uint32_t queue_size,
    void (* fp)(const ImageConstPtr &),
    const TransportHints * transport_hints = nullptr)

and

  Subscriber subscribe(
    const std::string & base_topic, uint32_t queue_size,
    void (* fp)(const ImageConstPtr &),
    const TransportHints * transport_hints = nullptr,
    const rclcpp::SubscriptionOptions options = rclcpp::SubscriptionOptions())

are ambiguous.

jmachowinski commented 1 year ago

Recent merges fixed the issue