search

ros-perception / image_common

Common code for working with images in ROS
http://www.ros.org/wiki/image_common
124 stars 219 forks source link

Drop pkg-config logic to find yaml-cpp. #280

Closed mikepurvis closed 7 months ago

mikepurvis commented 1 year ago

Modern platforms include CMake find modules for yaml-cpp, including Ubuntu Focal:

https://packages.ubuntu.com/focal/amd64/libyaml-cpp-dev/filelist

This extra logic was tripping up my NixOS 23.05 build:

camera_calibration_parsers> -- Checking for module 'yaml-cpp'
camera_calibration_parsers> --   No package 'yaml-cpp' found
camera_calibration_parsers> CMake Error at CMakeLists.txt:33 (if):
camera_calibration_parsers>   if given arguments:
camera_calibration_parsers>     "VERSION_GREATER" "0.5"
camera_calibration_parsers>   Unknown arguments specified