search

ros-perception / image_common

Common code for working with images in ROS
http://www.ros.org/wiki/image_common
124 stars 219 forks source link

Fix downstream regressions due to subscribe overloads #284

Closed adityapande-1995 closed 1 year ago

adityapande-1995 commented 1 year ago

Fixes https://github.com/ros-perception/image_common/issues/279 for humble

saikishor commented 1 year ago

Hello!

When can we expect this to be merged?

ahcorde commented 1 year ago

@adityapande-1995 can you run ci?

saikishor commented 1 year ago

@ahcorde Thank you for such an imminent response. It's just that the recent changes broke some downstream packages. Thanks for understanding :)

ahcorde commented 1 year ago
saikishor commented 1 year ago

Hello @ahcorde!

Once the upstream build pass, could you tag and release it as well?

Thank you,

Best Regards, Sai

ahcorde commented 1 year ago

@saikishor done here https://github.com/ros/rosdistro/pull/38240#event-10088006573

saikishor commented 1 year ago

Thanks a lot @ahcorde