search

ros-perception / image_common

Common code for working with images in ROS
http://www.ros.org/wiki/image_common
124 stars 219 forks source link

Camera & info synchronization check timer wrong seconds value #286

Open nakai-omer opened 11 months ago

nakai-omer commented 11 months ago

Hello,

Seems like there is a glitch in the initializing of the timer that checks that camera and camera_info msgs are synced. The error message displayed to the user states 10 seconds, while the timer is ticked every 1 second. https://github.com/ros-perception/image_common/blob/a32e834234af161c19d9a2b1cc03991dd6af53e7/image_transport/src/camera_subscriber.cpp#L88 https://github.com/ros-perception/image_common/blob/a32e834234af161c19d9a2b1cc03991dd6af53e7/image_transport/src/camera_subscriber.cpp#L136

nakai-omer commented 11 months ago

Don't mind creating a PR for this, just need to know which one is better making the timer every 10 seconds, or changing the warning message