search

ros-perception / image_common

Common code for working with images in ROS
http://www.ros.org/wiki/image_common
130 stars 226 forks source link

Add `camera_info_manager_py` to this repo? #331

Closed civerachb-cpr closed 2 days ago

civerachb-cpr commented 1 week ago

Back in the distant past there was a camera_info_manager_py package: https://github.com/ros-perception/camera_info_manager_py. It seems this repo has been effectively abandoned, with the last commits being about 8 years ago.

We've forked that repo and are trying to get it re-released for Humble and Jazzy, since it's a dependency of the axis_camera driver, which we'd also like to get released. However, we're getting some pushback from OSRF about releasing a fork of the original package. They've proposed that rather than releasing our fork, that they'd like to see camera_info_manager_py merged here and released by your team. See: https://github.com/ros/rosdistro/pull/43325#issuecomment-2486164358

Are you open to this? If so, I can open merge requests against your Jazzy and Humble branches to add the new package, and then hopefully you can bloom the repo to get it released officially through OSRF's buildfarm.

Conversely, if you don't want to take ownership of camera_info_manager_py, or have some alternative proposal to get it released, could you please leave a comment on https://github.com/ros/rosdistro/pull/43325?

Thanks!

ahcorde commented 6 days ago

Hi @civerachb-cpr,

please open the PR with the camera_info_manager_py package, I will take care of blooming the package and possible PRs.

civerachb-cpr commented 5 days ago

@ahcorde , done! I've made two MRs, one for humble and one for jazzy:

We've been using the clearpathrobotics/camera_info_manager_py/ros2 branch successfully for both distros, so the code is identical. I've set the camera_info_manager_py package version to match with the current version of the other packages in each branch to hopefully make blooming easier for you.

ahcorde commented 2 days ago

Releases