Closed Kotochleb closed 1 month ago
I'm not sure why there is a "return result" in any of those cases - I would think we should iterate through all the parameter settings by completing the for loop (and then there is a return after the reconfigure callback is called). I think we should actually remove the lines entirely (not change to a break).
I'm not sure why there is a "return result" in any of those cases
@mikeferguson this is precisely what caused my confusion and said lack of said confidence in making changes. If you think removing the return
entirely is a fine fix I can submit PR soon.
Looks like fix is merged to Rolling, backports in progress
As in the title,
image_publisher_node
doesn't account forcamera_info_url
on the initialization when launched as a standalone node on Humble. For some reason, it skips reading it. When the same parameter is changed dynamically after the node started, everything works just fine. The simplest walk-round I found was to changereturn result
withbreak
in thepram_change_callback
like so:Yet, I feel like there should be a better solution to this, and I do not feel confident enough with the original implementation to submit a good enough bugfix PR.