search

ros-perception / image_pipeline

An image processing pipeline for ROS.
Other
763 stars 715 forks source link

Crop Decimate Node: On Parameter Set #967

Open mhubii opened 2 months ago

mhubii commented 2 months ago

Thank you for providing this great package.

I believe dynamic parameters are not supported in

https://github.com/ros-perception/image_pipeline/blob/rolling/image_proc/src/crop_decimate.cpp

ahcorde commented 2 months ago

There is no support for now, but happy to review a PR if you decide to contribute

mhubii commented 2 months ago

Would the PR aim at rolling?

ahcorde commented 2 months ago

@mhubii yes, and we can backport the changes later if the PR doesn´t break ABI or API