Closed mergify[bot] closed 4 months ago
Cherry-pick of 78d80f77b75bb80feb29484ed8fc6791a4c1deb9 has failed:
On branch mergify/bp/iron/pr-985
Your branch is up to date with 'origin/iron'.
You are currently cherry-picking commit 78d80f7.
(fix conflicts and run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Changes to be committed:
modified: image_publisher/include/image_publisher/image_publisher.hpp
modified: image_publisher/src/image_publisher.cpp
Unmerged paths:
(use "git add/rm <file>..." as appropriate to mark resolution)
deleted by us: image_publisher/doc/components.rst
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Currently, the default value for focal length when no camera info is provided defaults to
1.0
rendering whole approximate intrinsics and projection matrices useless. Based on this article, I propose a better approximation of the focal length based on the field of view of the camera.For most of the use cases, users will either know the field of view of the camera the used, or they already calibrated it ahead of time.
If there is some documentation to fill. please let me know.
This PR should be straightforward to port it to
Humble
,Iron
andJazzy
.This is an automatic backport of pull request #985 done by Mergify.