ros-perception / image_transport_plugins

A set of plugins for publishing and subscribing to sensor_msgs/Image topics in representations other than raw pixel data.
BSD 3-Clause "New" or "Revised" License
55 stars 120 forks source link

add transport scoped parameters for CompressedPublisher #143

Closed bmegli closed 1 year ago

bmegli commented 1 year ago

Fix for #140

This is #142 re-targeted at rolling

Changes

Compared to #142

runtime reconfiguration

rolling supports runtime reconfiguration (reads params at the beginning of publish)

This forced us to synchronize deprecated values to correct ones. Otherwise deprecated values would not be used.

I purposefully synchronize only in deprecated -> non-deprecated direction.

nested attributes

Handler emitting deprecation warnings now handles nested attributes (like tiff.xdpi)

warnings

Now not emitted if new value was already set like deprecated one.

This will not emit warnings if somebody is using default values (not setting anything)

structure

All constants (parameter definition)

Next Steps

Again, this only targets compressed_publisher

If we agree on direction I can rework the rest along.

Refactoring

If generalizing for multiple transports:

In particular header and implementation would be further cleared from (common) parameter related code