ros-perception / image_transport_plugins

A set of plugins for publishing and subscribing to sensor_msgs/Image topics in representations other than raw pixel data.
BSD 3-Clause "New" or "Revised" License
58 stars 119 forks source link

[ROS2] reconfigurable transport scoped parameters for theora #146

Closed bmegli closed 1 year ago

bmegli commented 1 year ago

140 fix for theora_image_transport (publisher and subscriber)

108 like (runtime reconfigurable)

Implementation is #143 like + minor deviation for publisher.

The original logic behind dynamic reconfigure callbacks was kept.

publisher notes

The publisher is more complex here

This is different from all other transport scoped changes so far where we could make transport reconfigurable without depending on parameter event monitoring (in the spirit of #108).

The difference is only in setting/resetting/checking flag but event handling code exists only for the purpose of deprecated parameters in other transports.

code repetition

There is some code repetition between:

This should be temporary until deprecated parameters are removed.

The way to proceed was sketched in:

bmegli commented 1 year ago

Should be fixed now.

The only deviation was in subscriber which has parameter post_processing_level, the comments where based on it.

ijnek commented 1 year ago

@Mergifyio backport iron

mergify[bot] commented 1 year ago

backport iron

✅ Backports have been created

* [#147 [ROS2] reconfigurable transport scoped parameters for theora (backport #146)](https://github.com/ros-perception/image_transport_plugins/pull/147) has been created for branch `iron`