search

ros-perception / image_transport_tutorials

ROS 2 tutorials for image_transport.
Apache License 2.0
50 stars 11 forks source link

Cleanup to work on Rolling. #5

Closed clalancette closed 2 years ago

clalancette commented 2 years ago

This does a number of things:

  1. It adds in the missing LICENSE and CONTRIBUTING.md files
  2. It cleans up the CMakeLists.txt to use the current best practices
  3. It cleans up the code just a bit here and there to conform to our standards.

With all of this in place, we can now build against Rolling. Note that this should not be used for Galactic or Foxy, so we should probably make separate branches for those.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

jacobperron commented 2 years ago

You beat me to creating branches for the other distros, though I'm not sure this package is actually works in Foxy (I don't recall anyone testing against it). We also haven't released this package into any distro yet.

clalancette commented 2 years ago

You beat me to creating branches for the other distros, though I'm not sure this package is actually works in Foxy (I don't recall anyone testing against it). We also haven't released this package into any distro yet.

I tested that it at least builds on Foxy and Galactic, but I didn't go further than that.