[Windows][hydro] Use ${GTEST_LIBRARIES} for more portable gtest library linkage.

ros-perception / laser_assembler

Provides nodes to assemble point clouds from either LaserScan or PointCloud messages

40 stars 60 forks source link

[Windows][hydro] Use ${GTEST_LIBRARIES} for more portable gtest library linkage. #25

Closed seanyen closed 5 years ago

seanyen commented 5 years ago

This problems manifest for the environment where "gtest" is not an exported target. I am copying the implementation here to make it more portable.

https://github.com/ros-perception/image_common/blob/hydro-devel/camera_info_manager/CMakeLists.txt#L28-L37

seanyen commented 5 years ago

@jonbinney This is a fix to unblock the run_tests build breaks on Windows. (Verified in https://aka.ms/ros project.) Hope you can take a look. Thanks!

seanyen commented 5 years ago

@acxz @jonbinney Sorry to ping you again. Hope I can get some feedback to move this PR forward!

jonbinney commented 5 years ago

@seanyen I tried this out on linux (18.04, melodic ros distro) and it didn't break anything, so i'll go ahead and merge. Thanks!