ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.
BSD 3-Clause "New" or "Revised" License
161 stars 199 forks source link

Added DynamicReconfigure for RangeFilter #111

Closed EricWiener closed 3 years ago

EricWiener commented 3 years ago

Tried to make as few changes as possible (leaving style as is and leaving implementation in the header file).

Also tried to make the code backward compatible.

If you want, I'd also be happy to clean up the styling a bit and move the implementation into a .cpp file, but didn't want to do it without checking first.

jonbinney commented 3 years ago

Looks good; thanks @EricWiener !