search

ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.
BSD 3-Clause "New" or "Revised" License
161 stars 199 forks source link

change access specifiers for wrappers #127

Closed renan028 closed 2 years ago

renan028 commented 2 years ago

changing access specifier to protected (instead of private) so we can derive from base and change parameters dynamically with wrappers

jonbinney commented 2 years ago

@renan028 what rosdistro are you on? Indigo-devel is pretty old

jonbinney commented 2 years ago

Ooops nevermind... i don't know my alphabet. Indigo is the current ros1 branch. This change looks good to me. Merging.

jonbinney commented 2 years ago

Wait I was right the first time.... kinetic-devel is the current ros1 branch. Are you still running indigo? Or jade?

renan028 commented 2 years ago

Wait I was right the first time.... kinetic-devel is the current ros1 branch. Are you still running indigo? Or jade?

I am using melodic. But if you check: https://index.ros.org/search/?term=laser_filters And check the VCS version: https://index.ros.org/r/laser_filters/github-ros-perception-laser_filters/ It is indigo-devel

Edit: ok, just see that noetic is kinect-devel. Maybe melodic is just wrong. It would be nice to have the changes in kinect as well then.

jonbinney commented 2 years ago

You're right.... why did i make a kinetic devel branch? Huh.

jonbinney commented 2 years ago

I guess I could just rename kinetic-devel to noetic-devel and things would make sense.