search

ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.
BSD 3-Clause "New" or "Revised" License
161 stars 199 forks source link

Fix compiler warnings #128

Closed erwinbonsmatopic closed 2 years ago

erwinbonsmatopic commented 2 years ago

Fix all compiler warnings.

Fixed following warnings concerning filters header file includes: warning Including header <filters/filter_base.h> is deprecated, include <filters/filter_base.hpp> instead. [-Wcpp] Also fixed format warning in speckle_filter.cpp: warning: format ‘%i’ expects argument of type ‘int’, but argument 8 has type ‘std::vector<float>::size_type’ {aka ‘long unsigned int’} [-Wformat=]

Btw, this is the first in a series of intended PRs. The following ones will include additional unit tests and performance improvements.

JaccovdS commented 2 years ago

@jonbinney ping

jonbinney commented 2 years ago

@JaccovdS looks like the compiler isn't finding the headers in CI - ideas?

jonbinney commented 2 years ago

Oh..... i think the headers didn't change until noetic. I've been resisting creating a noetic-devel branch, but that might be needed here.

jonbinney commented 2 years ago

Well it seems that kinetic and melodic actually use the indigo-devel branch. So I think I can just rename the kinetic-devel branch to noetic-devel, and then release into noetic from that. Let me think it over.

erwinbonsmatopic commented 2 years ago

@jonbinney, getting rid of compiler warnings is good practice, so that's why I did so. However, if these changes have too much impact on your CI and release set-up, we can park this PR. The other PRs do not depend on this. On the other hand, it may be good to properly support noetic. It's your call.

jonbinney commented 2 years ago

It's worth getting this merged. I created a net noetic-devel branch and I'm cleaning up CI here: https://github.com/ros-perception/laser_filters/pull/138 Once that gets merged I'll retarget this PR to the new branch and merge it.