ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.
BSD 3-Clause "New" or "Revised" License
161 stars 199 forks source link

Speed up speckle filter implementation #130

Closed erwinbonsmatopic closed 2 years ago

erwinbonsmatopic commented 2 years ago

These changes improve performance by a factor three.

Summary of changes:

JaccovdS commented 2 years ago

@jonbinney ping

jonbinney commented 2 years ago

@Patrick-Lascombe or @reinzor do either of you have time to review this code? I'm not very familiar with the speckle filter.

Patrick-Lascombe commented 2 years ago

From what I can see the behavior is identical, but since I'm no longer using ROS1 I couldn't test it. Maybe @reinzor or someone else can test it more thoroughly.

reinzor commented 2 years ago

I will try to test it in our set-up today

reinzor commented 2 years ago

Seems to work fine in simulation; today we will perform some more tests on our hardware setup

YannickdeHoop commented 2 years ago

Seems to work fine with an actual hardware setup