ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.
BSD 3-Clause "New" or "Revised" License
161 stars 199 forks source link

Create shadow filter tests #141

Closed erwinbonsmatopic closed 2 years ago

erwinbonsmatopic commented 2 years ago

We want to speed up the shadow filter. However, as there were no tests yet, this PR adds those in preparation of that.

These tests test (and document) the current logic of the filter.

The filter logic seems a bit primitive in how it recognizes shadows. Then again, the input data in the unit tests is also not realistic, so I assume it works fine in practice.

This set of tests is just a starting point to guard against regressions. If others want to, they can add more realistic tests as needed.