ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.
BSD 3-Clause "New" or "Revised" License
166 stars 204 forks source link

add check inf or nan of input laser_scan intensities #27

Closed aginika closed 9 years ago

aginika commented 9 years ago

When we use laser_filters/LaserScanIntensityFilterwith gazebo, this will die because overflowed value is passed to array index around https://github.com/ros-perception/laser_filters/blob/indigo-devel/include/laser_filters/intensity_filter.h#L96-L99

So I added to check the value of intensities and do min compare to prevent overflowed int generating.

k-okada commented 9 years ago

+1, lgtm

jonbinney commented 9 years ago

Thanks @aginika!

furushchev commented 8 years ago

seems need another fix: https://github.com/ros-perception/laser_filters/pull/34