fix: segfault on accessing out of index at histogram array

ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.

BSD 3-Clause "New" or "Revised" License

166 stars 204 forks source link

Closed furushchev closed 8 years ago

furushchev commented 8 years ago

current codes occurs yet segmentation fault because of access to out of index on histogram array. This PR provides:

check if intensity value is infinity or negative, which causes out of index access.
not compute histogram when display_histogram is disabled

jonbinney commented 8 years ago

Thanks for cleaning up the dist_histogram flag.

jonbinney commented 8 years ago

Code looks good and tests pass. Thanks @furushchev for contributing this!

k-okada commented 8 years ago

great! can we release new version, so we can use fixed version as deb ?

jonbinney commented 8 years ago

Sure, I'll try and release in the next day or two

jonbinney commented 8 years ago

furushchev commented 8 years ago

@jonbinney Thank you for releasing! :clap: