ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.
BSD 3-Clause "New" or "Revised" License
166 stars 204 forks source link

Removed deprecated warning from footprint filter #43

Closed naveedhd closed 8 years ago

naveedhd commented 8 years ago

Ignore if I am totally wrong or inform if more changes required and I will do it.

jonbinney commented 8 years ago

Hi @naveedhd this was deprecated before I started maintaining laser_filters, so I don't know the whole story about why it happened. I'm assuming that it was used primarily for the PR2, and someone decided it would be better to just have a PR2 specific one (PR2LaserScanFootprintFilter)

What robot do you use it on? Do you think it is generic enough to work for many different robots?

naveedhd commented 8 years ago

Hi @jonbinney,

It is not used in our robots. I just followed #29 .

Actually I don't know really. My guess is it wont be used generally so should have deprecated warning.

jonbinney commented 8 years ago

Ah yes, I forgot about that conversation entirely. I'll merge this now. Thanks @naveedhd !