search

ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.
BSD 3-Clause "New" or "Revised" License
173 stars 204 forks source link

change range_filter to infinity for it to work with obstacle_layer #56

Closed jabbenseth closed 7 years ago

jabbenseth commented 7 years ago

if you use the ´inf_is_valid´ parameter raytracing is still possible for scans out of the window. Useful for laserscanners that may deliver ranges > range_max or a more detailed discrimination on which limit is not met

jonbinney commented 7 years ago

Thanks @ipa-jba ! This looks like a great added feature, and seems to be backwards compatible. I made one comment about changing a variable name; after you do that I'll merge this.

jabbenseth commented 7 years ago

@jonbinney there you go.

Who keeps track of the wiki page? I can add the new interface to the documentation once the PR is merged and note that this is an "unreleased but available" interface, or do you update the wiki only with new releases?

jonbinney commented 7 years ago

Merged - thanks @ipa-jba !

There's not anyone in particular who keeps track of the wiki. It would be great if you do as you suggest - add the new feature perhaps with an "added August 2017" note so that people can realize that they may need to get the package from source.

I'll create issues to remind myself to do releases soon so that everyone can get this feature from debs. Out of curiosity, which ROS distro are you primarily using?

jabbenseth commented 7 years ago

I use indigo as well as kinetic. Thanks for taking care of the release. I will update the wiki page at work tomorrow