Make laser_filters build for ros2 (on windows 10)

ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.

BSD 3-Clause "New" or "Revised" License

164 stars 200 forks source link

Make laser_filters build for ros2 (on windows 10) #60

Closed bfjelds closed 6 years ago

bfjelds commented 6 years ago

Working towards enabling laser_filters in ROS2. This provides ability to build and updates for ROS2 constructs (like Node vs NodeHandle, LaserScan's new namespace).

There are some gaps (TransformListener's waitForTransform, time handling, test code, parameter handling, timers), but it builds and runs.

jonbinney commented 6 years ago

Code looks good. I don't have a setup for testing this, but since certainly can't break anything (no ros2 functionality to break yet), I'm going to just merge this. Thanks @bfjelds !

tfoote commented 1 year ago

The comment about waitForTransform being missing was flagged to me. Note that waitForTransform has been replaced by canTransform with a timeout.