ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.
BSD 3-Clause "New" or "Revised" License
164 stars 200 forks source link

Release into Melodic #64

Closed clalancette closed 6 years ago

clalancette commented 6 years ago

It looks like all of the dependencies for this package are available in Melodic, so it would be great to get this released. Thanks in advance.

jonbinney commented 6 years ago

@clalancette I'll try and get to this tonight.

jonbinney commented 6 years ago

Argh, didn't finish. Will try again tomorrow. I want to build this first, but need to setup docker since I don't have an 18.04 machine handy.

clalancette commented 6 years ago

Great, thanks for taking a look.

Not sure if it helps at all, but I've been pretty happy using LXC to do my development on bionic: https://help.ubuntu.com/lts/serverguide/lxc.html . You'd basically do:

sudo apt-get install lxc
sudo lxc-create -t download -n u1 -- --dist ubuntu --release bionic --arch amd64

And then you can get into the container with:

sudo lxc-attach -n u1
jonbinney commented 6 years ago

Got my container up and running, but didn't have time to test. Went ahead and released anyway; maybe we get lucky and the build works? If not I'll investigate further.

jonbinney commented 6 years ago

It built! Hooray!