Fixed naming of laser filter plugins in yaml files

ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.

BSD 3-Clause "New" or "Revised" License

164 stars 200 forks source link

Fixed naming of laser filter plugins in yaml files #70

Closed YoshuaNava closed 3 years ago

YoshuaNava commented 5 years ago

This PR solves issue #69.

I just appended the prefix laser_filters/ to all the filter plugins call in this package yaml files.

jonbinney commented 3 years ago

@YoshuaNava thanks for this fix. I'll also forward-port it to the kinetic-devel branch.

RohanDwivedi commented 2 years ago

Hi, @YoshuaNava I installed the melodic branch of map_laser package from the ros melodic repo sudo apt-get install ros-melodic-map-filter which depends on this filter, yet the issue doesn't seem to have been resolved over there yet! Can I understand how that can be done? update: fixed it, my bad, the yaml file in the package was not following the convention

https://github.com/wg-perception/people/issues/103

jonbinney commented 2 years ago

@RohanDwivedi that's probably because this package hasn't been released on melodic since the fix was merged. So the source code in this repo has the fix, but the debian packages don't. Can you try cloning the indigo-devel version of this repo to your catkin workspace, recompiling, and see if that fixes the problem?