search

ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.
BSD 3-Clause "New" or "Revised" License
164 stars 200 forks source link

[Windows][indigo] Use ${GTEST_LIBRARIES} for more portable gtest library linkage. #72

Closed seanyen closed 5 years ago

seanyen commented 5 years ago

This problems manifest for the environment where "gtest" is not an exported target. I am copying the implementation here to make it more portable.

https://github.com/ros-perception/image_common/blob/hydro-devel/camera_info_manager/CMakeLists.txt#L28-L37

seanyen commented 5 years ago

@jonbinney Sorry I didn't link this one with https://github.com/ros-perception/laser_assembler/pull/25. The PR is basically doing the same fix. Hope you can take a look. Thanks!

jonbinney commented 5 years ago

Compiles on melodic/18.04, merging. Tanks @seanyen !

seanyen commented 5 years ago

Thanks!