Closed DLu closed 11 years ago
Hi David, I've chosen a slightly different approach in my pull request, so we don't have to rely on the integer overflow producing a negative number.
Good call. Thanks!
Wow, that was quick! :-)
Sorry for the delay, GSOC keeps us busy these days :) The histogram is actually for debug purposes only. @mintar patch was modifying the filtered_scan. Is that a desired behavior ? I did that instead: 2da0e525b1bd2c58a5269901eb57325fece1cd9e
Please review and close the bug appropriately.
@vrabaud Thanks, this works. I didn't care about modifying the filtered_scan, because the relevant points are removed anyway by the line before (by setting the range to max + 1), so the intensities that I modified should be ignored anyway. That behaviour isn't "desired", it shouldn't matter one way or the other.
I don't have the permissions to close this issue, but I just verified it works now, so feel free to close the issue.
cool, thx for the feedback !
If intensities in a laser scan are large enough, intensity filter will segfault.
Given an intensity of 3e20 (for example), so this line results in an integer so large that it overflows. However the negative index results in the segfault here
Corrected version: