ros-perception / laser_geometry

Provides the LaserProjection class for turning laser scan data into point clouds.
BSD 3-Clause "New" or "Revised" License
157 stars 114 forks source link

Drop CMake extras redundant with eigen3_cmake_module #50

Closed hidmic closed 4 years ago

hidmic commented 4 years ago

Precisely what the title says. Said extras were redundant with eigen3_cmake_module and caused trouble in downstream packages.

hidmic commented 4 years ago

CI up to tf2_sensor_msgs, laser_geometry and above:

hidmic commented 4 years ago

This one's ready to go. Who'd be the right person to do so?

wjwwood commented 4 years ago

@jonbinney do you want to look first, or can I merge?

jonbinney commented 4 years ago

@wjwwood LGTM, feel free to merge.