search

ros-perception / laser_geometry

Provides the LaserProjection class for turning laser scan data into point clouds.
BSD 3-Clause "New" or "Revised" License
157 stars 114 forks source link

use target_include_directories #55

Closed Karsten1987 closed 4 years ago

Karsten1987 commented 4 years ago

thanks @jonbinney for merging #54 This is simple a backport of the same commit onto the eloquent branch. I would very much appreciate to see this patch being backported and released into eloquent.

Signed-off-by: Karsten Knese karsten@openrobotics.org

Karsten1987 commented 4 years ago

I don't run CI on this as I think it's fair to rely on the PR job which came back green with all tests passed.

Karsten1987 commented 4 years ago

Do you think you could cut an eloquent release for this?

jonbinney commented 4 years ago

I created the changelog and bumped the version on the eloquent branch in this repo, but i don't have push permissions for the ros2 release repo to do the release. @wjwwood could you give me write access to https://github.com/ros2-gbp/laser_geometry-release ?

wjwwood commented 4 years ago

@jonbinney I've added you, but you have to accept the invitation first.

wjwwood commented 4 years ago

I have given you the ⚡️.

jonbinney commented 4 years ago

Thanks @wjwwood ! @Karsten1987 I've made the release: https://github.com/ros/rosdistro/pull/23691