[ROS-O] fix package.xml bugs and compatibility with modern systems

[v4hn]

@jonbinney I'll pick you up on your promise here. :sunglasses:

Concerning the patches:

• missing build_export declarations was introduced with the last merged patch #87
• rostest was plainly missing
• the setuptools change works for a very long time already, no concern here
• the c++11 declaration breaks modern logcxx (and by now also other major libraries) requiring c++14 (and 17).

[jonbinney]

Compiles without warning and tests pass on Noetic/20.04. I'm not a maintainer for this package though - @clalancette would you consider merging this? I'd suggest creating a noetic-devel branch and merging this into that branch to avoid possibly breaking anyone's archaic built-from-source copies of old ros versions.

[v4hn]

Thanks for the review.

I'd suggest creating a noetic-devel branch and merging this into that branch to avoid possibly breaking anyone's archaic built-from-source copies of old ros versions.

The first two commits are plain bugs in the kinetic-devel branch that should ideally be fixed there and someone's "archaic built-from-source" setup failed due to the missing export_depend in downstream packages.

The setuptools patch should be compatible with Ubuntu 16.04, but I did not verify and it might be problematic. The c++ version patch is not directly compatible with Ubuntu 16.04.

Feel free to rearrange the patches upstream or ask me to provide different PRs.