Open wkentaro opened 8 years ago
I tried to discussion this topic at https://github.com/ros-perception/vision_opencv/pull/56#issue-53170691
this package contains a lot of new message, show we create opencv_msgs that holds opencv basic data structure ? or ask other packages (geometry_msgs or others ) to add new messages?
Basic question is
current msg try to support opencv types as ros messages, and would like to know if this is the right direction
IMO, the types in opencv are mostly well refined and creating message for that is reasonable thing, because it seems that OpenCV is more famous than ROS. But I also think we can reuse messages in geometry_msgs for some messages in this package, for example
z=0
.points[:].z=0
.if this is ok, we need to check if current implementation covers all opencv data types
Maybe we can add new messages when we need. We can discuss about adding a new message at that time.
Not approved no changes overview
Not approved no changes overview
Denied
There are many reusable ROS messages in this package. Why not separating them into an another package like pcl_msgs?