ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps
64 stars 70 forks source link

Proposal of separating ROS messages into an another package (maybe cv_msgs?) like pcl_msgs #10

Open wkentaro opened 8 years ago

wkentaro commented 8 years ago

There are many reusable ROS messages in this package. Why not separating them into an another package like pcl_msgs?

k-okada commented 8 years ago

I tried to discussion this topic at https://github.com/ros-perception/vision_opencv/pull/56#issue-53170691

this package contains a lot of new message, show we create opencv_msgs that holds opencv basic data structure ? or ask other packages (geometry_msgs or others ) to add new messages?

Basic question is

wkentaro commented 8 years ago

current msg try to support opencv types as ros messages, and would like to know if this is the right direction

IMO, the types in opencv are mostly well refined and creating message for that is reasonable thing, because it seems that OpenCV is more famous than ROS. But I also think we can reuse messages in geometry_msgs for some messages in this package, for example

if this is ok, we need to check if current implementation covers all opencv data types

Maybe we can add new messages when we need. We can discuss about adding a new message at that time.

hh129sss5 commented 2 years ago

Not approved no changes overview

hh129sss5 commented 2 years ago

Not approved no changes overview

Denied