search

ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps
65 stars 70 forks source link

[WIP] add info to how to contribute new features #110

Open k-okada opened 4 years ago

ivan1993br commented 4 years ago

Hi @k-okada,

Nice the contribution guideline addition, including the tutorial! One thing that I think it is not clear is if this package only contains the c++ samples(as it is - just a porting) from opencv or if we can add features on this samples(i.e. on the example that you used here, can I add the CLAHE to the histogramEqualization). Also, can I use samples from another place that besides here(like here)?

Thanks

k-okada commented 4 years ago

Hi

You can use samples from other places. I just afraid people put their code randomly and make repository messy. So I want to put some guidelines to show the set of codes to be put in this package.

So adding https://github.com/opencv/opencv/tree/22dbcf98c5fc1358bcb4660fe15a9ef8d2b4b388/samples/tapi would be good idea and add list of code as https://github.com/opencv/opencv/tree/22dbcf98c5fc1358bcb4660fe15a9ef8d2b4b388/samples/tapi, so that other pople can understand our next scope to which function to be added.

Based on same idea, I also require msg/ directory should have corresponding OpenCV data class. Of course there would be much better design of output messages, but, for example, re-use existing visualization node, we do not want to accept arbitrary message type.

-- ◉ Kei Okada

2020年10月9日(金) 21:29 Ivan Oliveira Tarifa notifications@github.com:

Hi @k-okada https://github.com/k-okada,

Nice the contribution guideline addition, including the tutorial! One thing that I think it is not clear is if this package only contains the c++ samples(as it is - just a porting) from opencv or if we can add features on this samples(i.e. on the example that you used here, can I add the CLAHE to the histogramEqualization). Also, can I use samples from another place that besides here https://github.com/opencv/opencv/tree/22dbcf98c5fc1358bcb4660fe15a9ef8d2b4b388/samples/cpp(like here https://github.com/opencv/opencv/tree/22dbcf98c5fc1358bcb4660fe15a9ef8d2b4b388/samples/tapi )?

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ros-perception/opencv_apps/pull/110#issuecomment-706152118, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYNXF55C3QBEUJK4WA6ADSJ36YZANCNFSM4SJS76AQ .