search

ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps
64 stars 70 forks source link

Modified hough-circle for color circle #13

Closed iory closed 8 years ago

iory commented 8 years ago

hough_circle

k-okada commented 8 years ago

I think there are two cases for color or gray for 'frame' image https://github.com/iory/opencv_apps/blob/1ffa870096a36d4e24d82a4c1a62e7e465d9d0d2/src/nodelet/hough_circles_nodelet.cpp#L146

iory commented 8 years ago

in gray scale, we should output gray scale image?

iory commented 8 years ago

https://github.com/iory/opencv_apps/blob/1ffa870096a36d4e24d82a4c1a62e7e465d9d0d2/src/nodelet/hough_circles_nodelet.cpp#L213-L215 This code is meaningless

k-okada commented 8 years ago

this is conflict, please rebase

iory commented 8 years ago

rebased

k-okada commented 8 years ago

thx