search

ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps
64 stars 70 forks source link

Add ignore nodelt condition for hydro #17

Closed iory closed 8 years ago

iory commented 8 years ago

Relate to https://github.com/ros-perception/opencv_apps/issues/16

wkentaro commented 8 years ago

maybe you should add comment about why the if block is necessary.

iory commented 8 years ago

OK

In hydro, sensor_msgs does'nt have 'CompressedImageConstPtr'. simple_compressed_example is using compessedimageconstptr and lk_flow lk_flow is using sensor_msgs::image::encodings (Please refer to below url) https://github.com/ros-perception/opencv_apps/blob/indigo/src/nodelet/simple_compressed_example_nodelet.cpp#L69 https://github.com/ros-perception/opencv_apps/blob/indigo/src/nodelet/lk_flow_nodelet.cpp#L127

wkentaro commented 8 years ago

Ah, I mean in the CMakeLists.txt.

iory commented 8 years ago

Oh, I misunderstood it. I wrote it in the CMakeLists.txt.

wkentaro commented 8 years ago

Looks good.

iory commented 8 years ago

Thanks!

2016-06-09 13:33 GMT+09:00 Kentaro Wada notifications@github.com:

Looks good.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ros-perception/opencv_apps/pull/17#issuecomment-224797723, or mute the thread https://github.com/notifications/unsubscribe/AEeS-gRLHDSJDP37J-WIPwhjE7mvG4Vrks5qJ5eCgaJpZM4IxLKF .

iory commented 8 years ago

Please merge this.

k-okada commented 8 years ago

this branch is target to indigo, I think

wkentaro commented 8 years ago

this branch is target to indigo, I think

@iory so you need to change the CMakeFile.txt of opencv_apps in the .travis.sh. to use this package on hydro.

k-okada commented 8 years ago

this has been closed via https://github.com/ros-perception/opencv_apps/pull/22