ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps
64 stars 70 forks source link

add launch files #20

Closed k-okada closed 8 years ago

k-okada commented 8 years ago

this will provide re-usable launch file for opencv_apps users

wkentaro commented 8 years ago

Is providing launch file for each node really useful for users? I think the ROS beginners can't use <include> tag in roslaunch and professionals don't use <include> because it is less customizable (can't use nodelet with an nodelet manager). IMO providing sample launch files is enough, because user can copy the lines from it.

k-okada commented 8 years ago

yes, I'm aware of nodelt case, and try to rewrite all launch file with nodelt and 'use_standalone' arg option to run manager for each launch file.

from https://github.com/ros-perception/vision_opencv/issues/121,

with launch file

◉ Kei Okada

On Thu, Aug 25, 2016 at 6:11 PM, Kentaro Wada notifications@github.com wrote:

Is providing launch file for each node really useful for users? I think the ROS beginners can't use tag in roslaunch and professionals don't use because it is less customizable (can't use nodelet with an nodelet manager). IMO providing sample launch files is enough, because user can copy the lines from it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ros-perception/opencv_apps/pull/20#issuecomment-242325330, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3H6-M0IyoRvDrLB34M9d3uUJqWtNks5qjVw1gaJpZM4JquBG .

130s commented 8 years ago

+1 for installing launch directory. Also +1 for the idea of making a node definition "portable/dependable" by making them a launch file.