proposal for chaning nodlet pkg/type name

ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps

64 stars 70 forks source link

proposal for chaning nodlet pkg/type name #21

Open k-okada opened 8 years ago

k-okada commented 8 years ago

format of nodelet_plugins.xml is

  <class name="example_pkg/MyNodeletClass" type="example_pkg::MyNodeletClass" base_class_type="nodelet::Nodelet">

http://wiki.ros.org/nodelet/Tutorials/Porting%20nodes%20to%20nodelets

If someonf is using nodelet already, this breaks API

@iory

iory commented 8 years ago

+1 to me

wkentaro commented 8 years ago

I agree with this change. But this breaks the nodelet API, so I think you should release a version before merging this, and release a major version afterward.

wkentaro commented 7 years ago

See https://github.com/ros-perception/opencv_apps/pull/59, it won't break API and just rename the nodelets. We can break API after releasing the new API.