Closed iory closed 7 years ago
please write code on top of https://github.com/ros-perception/opencv_apps/pull/25 and also add lines like // https://github.com/Itseez/opencv/blob/2.4/samples/cpp/lk_demo.cpp, to stop updating code. because if we have "original sample code", if some one look at code and want to fix them, we can say this code is based on original code, so I understand you want to change this, but do not have to. If not, we'll have never-ending code updating process.
◉ Kei Okada
On Tue, Aug 30, 2016 at 7:20 PM, iory notifications@github.com wrote:
related to
25 https://github.com/ros-perception/opencv_apps/pull/25
[image: smoothing]
https://cloud.githubusercontent.com/assets/4690682/18085593/be4ddb44-6ee6-11e6-95aa-f735d9cd8f6d.png
You can view, comment on, or merge this pull request online at:
https://github.com/ros-perception/opencv_apps/pull/26 Commit Summary
- [smoothing_filter] Add smoothing_filters
- [smoothing_filter] Add sample and test
File Changes
- M CMakeLists.txt https://github.com/ros-perception/opencv_apps/pull/26/files#diff-0 (6)
- A cfg/BilateralFilter.cfg https://github.com/ros-perception/opencv_apps/pull/26/files#diff-1 (13)
- A cfg/GaussianFilter.cfg https://github.com/ros-perception/opencv_apps/pull/26/files#diff-2 (13)
- A cfg/MedianFilter.cfg https://github.com/ros-perception/opencv_apps/pull/26/files#diff-3 (11)
- A cfg/NormalizedBlockFilter.cfg https://github.com/ros-perception/opencv_apps/pull/26/files#diff-4 (11)
- A launch/smoothing_filter.launch https://github.com/ros-perception/opencv_apps/pull/26/files#diff-5 (45)
- M nodelet_plugins.xml https://github.com/ros-perception/opencv_apps/pull/26/files#diff-6 (16)
- A src/nodelet/smoothing_filter_nodelet.cpp https://github.com/ros-perception/opencv_apps/pull/26/files#diff-7 (285)
- A test/test-smoothing_filter.test https://github.com/ros-perception/opencv_apps/pull/26/files#diff-8 (53)
Patch Links:
- https://github.com/ros-perception/opencv_apps/pull/26.patch
- https://github.com/ros-perception/opencv_apps/pull/26.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ros-perception/opencv_apps/pull/26, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3B-xlGSorKSNIjMOiPBiVfSr3sM6ks5qlAPUgaJpZM4JwXos .
OK, I fixed those points.
fixed in #32
@iory please add info to wiki page http://wiki.ros.org/opencv_apps
related to https://github.com/ros-perception/opencv_apps/pull/25