search

ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps
64 stars 70 forks source link

Add line segment detector(lsd) #35

Open iory opened 8 years ago

iory commented 8 years ago

lsd

k-okada commented 8 years ago

please put line_segment_detector.png so that we can put that imgae on http://wiki.ros.org/opencv_apps

iory commented 8 years ago

OK! I upload it. line_segment_detector

furushchev commented 8 years ago

need rebase origin/indigo (see #45)

k-okada commented 7 years ago

@iory failing on test -> https://travis-ci.org/ros-perception/opencv_apps/jobs/166045561

+ catkin_test_results --verbose build
Full test results for 'opencv_apps/test_results/opencv_apps/roslaunch-check__home_travis_catkin_ws_src_opencv_apps_launch_line_segment_detector.launch.xml'
-------------------------------------------------
<testsuite errors="0" failures="1" name="roslaunch-check__home_travis_catkin_ws_src_opencv_apps_launch_line_segment_detector.launch.xml" tests="1" time="1"><testcase classname="Results" name="test_ran" status="run" time="1"><failure message="roslaunch check [/home/travis/catkin_ws/src/opencv_apps/launch/line_segment_detector.launch] failed" type="" /></testcase><system-out>&lt;![CDATA[
[/home/travis/catkin_ws/src/opencv_apps/launch/line_segment_detector.launch]:
    cannot find node [line_segment_detector] in package [opencv_apps]
]]&gt;</system-out></testsuite>
-------------------------------------------------
Full test results for 'opencv_apps/test_results/opencv_apps/roslaunch-check__home_travis_catkin_ws_src_opencv_apps_test_test-line_segment_detector.test.xml'
-------------------------------------------------
<testsuite errors="0" failures="1" name="roslaunch-check__home_travis_catkin_ws_src_opencv_apps_test_test-line_segment_detector.test.xml" tests="1" time="1"><testcase classname="Results" name="test_ran" status="run" time="1"><failure message="roslaunch check [/home/travis/catkin_ws/src/opencv_apps/test/test-line_segment_detector.test] failed" type="" /></testcase><system-out>&lt;![CDATA[
[/home/travis/catkin_ws/src/opencv_apps/test/test-line_segment_detector.test]:
    cannot find node [line_segment_detector] in package [opencv_apps]
]]&gt;</system-out></testsuite>
-------------------------------------------------
opencv_apps/test_results/opencv_apps/roslaunch-check__home_travis_catkin_ws_src_opencv_apps_launch_line_segment_detector.launch.xml: 1 tests, 0 errors, 1 failures
opencv_apps/test_results/opencv_apps/roslaunch-check__home_travis_catkin_ws_src_opencv_apps_test_test-line_segment_detector.test.xml: 1 tests, 0 errors, 1 failures
Summary: 124 tests, 0 errors, 2 failures
+ catkin_test_results --all build
Skipping "catkin_tools_prebuild/package.xml": 'tests'
iory commented 7 years ago

Test passed. Please check these codes.

k-okada commented 7 years ago 
if(TARGET opencv_line_descriptor)
  set(OPENCV_HAVE_LINE_DESCRIPTOR TRUE)
endif()
if(OPENCV_HAVE_LINE_DESCRIPTOR)
  opencv_apps_add_nodelet(line_segment_detector
line_segment_detector/line_segment_detector
src/nodelet/line_segment_detector_nodelet.cpp) # ./lsd_lines.cpp
endif()

if target set, set OPENCV_HAVE.... and if OPENCV_HAVE.. is set, set target. seems very strange.... why are you confident with this.

-- ◉ Kei Okada

2017-04-03 11:47 GMT+09:00 iory notifications@github.com:

@iory commented on this pull request.

In CMakeLists.txt https://github.com/ros-perception/opencv_apps/pull/35#discussion_r109333296 :

@@ -9,6 +9,9 @@ message(STATUS "OpenCV Components: ${OpenCV_LIB_COMPONENTS}") if(OpenCV_VERSION VERSION_LESS "3.0" OR TARGET opencv_optflow) set(OPENCV_HAVE_OPTFLOW TRUE) endif() +if(TARGET opencv_line_descriptor)

This is function of opencv3. So we need target.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ros-perception/opencv_apps/pull/35#discussion_r109333296, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3DbYZnV_MncJUsZRnm3zQSmb21__ks5rsF3cgaJpZM4J-LYQ .

iory commented 7 years ago

I understand that "if(TARGET opencv_line_descriptor)" is true when opencv have line_segment_descriptor (in opencv3). Is this understanding wrong?

k-okada commented 7 years ago

I see, you're correct. that's why we need find_packge(OpenCV) and sometime we have trouble when we install ros-indgo-opencv3, becuase ros-indigo-cv-bridge is linked against opnecv2, but find_packaage(OpenCV) look for ros-indigo-opencv3

-- ◉ Kei Okada

2017-04-04 18:46 GMT+09:00 iory notifications@github.com:

I understand that "if(TARGET opencv_line_descriptor)" is true when opencv have line_segment_descriptor (in opencv3). Is this understanding wrong?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ros-perception/opencv_apps/pull/35#issuecomment-291449689, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3BGbkVFHuZLXHJkH0ImOQQ6jp6HRks5rshF3gaJpZM4J-LYQ .

k-okada commented 6 years ago

@iory please rebase origin/master