search

ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps
64 stars 70 forks source link

Add pyramids_nodelet #37

Closed iory closed 6 years ago

iory commented 7 years ago

Add pyramids_nodelet ros version https://github.com/opencv/opencv/blob/master/samples/cpp/tutorial_code/ImgProc/Pyramids.cpp

k-okada commented 7 years ago

please add pyramids_result.png so that we can put that imgae on http://wiki.ros.org/opencv_apps

iory commented 7 years ago

OK! I upload it. pyramids_result

furushchev commented 7 years ago

need rebase origin/indigo (see #45)

iory commented 7 years ago

rebased

iory commented 7 years ago

Please merge this.

k-okada commented 7 years ago

https://cloud.githubusercontent.com/assets/4690682/18719025/948e5cee-8060-11e6-99a1-57dc08adf995.png Is this the result?

iory commented 7 years ago

pyramids nodelet changes image size. So, the result is correct. The image size are changed

k-okada commented 7 years ago

iory, iory, iory,.... If you wan to show "pyramid image", usually people preare something like this. http://labs.eecs.tottori-u.ac.jp/sd/Member/oyamada/OpenCV/html/_images/messipyr.jpg http://en.pudn.com/downloads183/sourcecode/graph/texture_mapping/detail857700_en.html

-- ◉ Kei Okada

2017-03-30 16:02 GMT+09:00 iory notifications@github.com:

pyramids nodelet changes image size. So, the result is correct. The image size are changed

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ros-perception/opencv_apps/pull/37#issuecomment-290320816, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3MznZN4WV7jJg_N9O7ecrbKDAz78ks5rq1OWgaJpZM4J_5c4 .

iory commented 7 years ago

Oh, I see. I learned that. How about this image after

iory commented 7 years ago

border version after

k-okada commented 7 years ago

very nice !!! can you also show the script to write this file? I'd like to think if we can add that to https://github.com/ros-perception/opencv_apps/pull/37/files#diff-5d2a58ed88aad71aded9ee0e0a9590f9R17

iory commented 7 years ago

Can we execute imagemagick code? Is this not general solution?

convert pyramids_result_x4.png pyramids_result_x3.png -bordercolor white -border 20 -geometry +0+0 -composite pyramids_result_x2.png -bordercolor white -border 20 -geometry +20+20 -composite pyramids_result_x1.png -bordercolor white -border 20 -geometry +40+40 -composite  pyramids_result.jpg
k-okada commented 7 years ago

one solution is to use https://github.com/ros-perception/opencv_apps/pull/57 (or this change may too much) anyway we can update test code to output pyramids_result_x4.png pyramids_result_x3.png,pyramids_result_x2.png ...

iory commented 7 years ago

Applying adding image nodelet's result is following.

pyramids_result

k-okada commented 7 years ago

you can change alpha parameter

k-okada commented 6 years ago

@iory please use alpha to get better result images

k-okada commented 6 years ago

@iory please update roswiki documents