search

ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps
64 stars 70 forks source link

[face_detection_nodelet.cpp] publish face roi image #40

Closed furushchev closed 7 years ago

furushchev commented 7 years ago

rebased origin/indigo (see #45)

k-okada commented 7 years ago

please update roswiki -> http://wiki.ros.org/opencv_apps#face_detection and also update test code https://github.com/ros-perception/opencv_apps/blob/indigo/test/test-face_detection.test#L18-L20

furushchev commented 7 years ago

updated test code https://github.com/ros-perception/opencv_apps/pull/47

furushchev commented 7 years ago

updated roswiki http://wiki.ros.org/action/info/opencv_apps?action=diff&rev2=18&rev1=17

k-okada commented 7 years ago

i see, how about to add only https://github.com/ros-perception/opencv_apps/pull/47/files#diff-f36def5ba71d78aa656285f4bb9e0d23R22 node, and do not run publishtest, because at this moment, we only publish and save face_detection/image but did not actually test if that is published on travis, we just run test code locally and see if we have output image file. Please also add face image file corresponds to

http://wiki.ros.org/opencv_apps?action=AttachFile&do=get&target=face_detection.png

◉ Kei Okada

2016-10-16 22:50 GMT+09:00 Furushchev notifications@github.com:

updated roswiki http://wiki.ros.org/action/info/opencv_apps?action=diff&rev2=18&rev1=17

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.