search

ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps
64 stars 70 forks source link

face_detection: fixed veresion of #47 #49

Closed k-okada closed 7 years ago

k-okada commented 7 years ago

I see, thanks removed 46490c3386d8933d3898d4af4fcdde3c5174aa09 and skip face_detection test on hydro

◉ Kei Okada

2016-10-25 18:18 GMT+09:00 Furushchev notifications@github.com:

@furushchev requested changes on this pull request.

In src/nodelet/face_detection_nodelet.cpp https://github.com/ros-perception/opencv_apps/pull/49#pullrequestreview-5610493 :

@@ -236,8 +236,13 @@ class FaceDetectionNodelet : public opencv_apps::Nodelet msgpub = advertise(*pnh_, "faces", 1);

 std::string face_cascade_name, eyes_cascade_name;

+#ifdef HYDRO

@k-okada https://github.com/k-okada Test seems failed because the default param value specified here will be overwritten by launch file: https://github.com/ros-perception/opencv_apps/blob/ indigo/launch/face_detection.launch#L10-L17

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ros-perception/opencv_apps/pull/49#pullrequestreview-5610493, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3O60fJYkZPETrV7SLG5Ztym-ojd0ks5q3clkgaJpZM4KezWh .