Set useless use_camera_info flag to false in default

ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps

64 stars 70 forks source link

Set useless use_camera_info flag to false in default #58

Closed wkentaro closed 7 years ago

wkentaro commented 7 years ago

This changes current behavior a little, but won't break current programs because all programs work without camera_info in actual. IMO, camera_info should not be subscribed if it is not used.

cc @iory

k-okada commented 7 years ago

since grep use_camera_info * | grep def | grep true returns nil, so I found currently we're expecting user to use use_camera_info with false, so I think we can merge this PR. One interesting thing is that I haven't hear anyone who had actually trouble on this, no issue, no ros answers (https://www.google.co.jp/?q=%2Bsite:answers.ros.org+opencv_apps). People are more trouble on opencv3 issue. That's very strange...

wkentaro commented 7 years ago

@k-okada Could you please merge this?