search

ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps
64 stars 70 forks source link

Fix namespace and pkg name of nodelets #59

Open wkentaro opened 7 years ago

wkentaro commented 7 years ago

In addition to https://github.com/ros-perception/opencv_apps/pull/21

wkentaro commented 7 years ago

@k-okada Why not release this first? Then we can revert f32add1 to break the API.

k-okada commented 7 years ago

can we display "DEPRECATED message" when someone using old API?

wkentaro commented 7 years ago

I think we need to create another nodelet class to do that, because resolving name is the task of loader, and the loader is in nodelet package for rosrun nodelet nodelet load .. or .. standalone ..

wkentaro commented 7 years ago

Added DeprecationWarning:

% rosrun nodelet nodelet standalone discrete_fourier_transform/discrete_fourier_transform
type is discrete_fourier_transform/discrete_fourier_transform
[ WARN] [1492379624.373237421]: [/discrete_fourier_transform_discrete_fourier_transform] [DiscreteFourierTransformNodelet::onInit] DeprecationWarning: Nodelet discrete_fourier_transform/discrete_fourier_transform is deprecated, and renamed to opencv_apps/discrete_fourier_transform.
wkentaro commented 7 years ago

@k-okada I think this is the most user friendly way to rename the nodelet. What do you think about this?