search

ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps
64 stars 70 forks source link

Threshold being reset to 50 for hough_lines #76

Closed danieljimeneznz closed 5 years ago

danieljimeneznz commented 6 years ago

Hi,

The threshold for some reason when using roslaunch params keeps on being reset to 50 whenever a threshold below 50 is used. The bug can be seen by setting the threshold to 25 in the .launch file provided and adding a NODELET_DEBUG(%d, threshold_); on line 217 of hough_lines_nodelet.cpp

furushchev commented 6 years ago

Hi, The threshold is defined at a range of 50-150 here: https://github.com/ros-perception/opencv_apps/blob/indigo/cfg/HoughLines.cfg#L45

I'm not sure how the range is determined but you can send a pull request if you have a rationale to change it. :-)

danieljimeneznz commented 6 years ago

Hi,

I managed to increase the threshold by decreasing the size of theta. Was just thinking, wouldn't it be an idea to have the slider in the debug_view go from 50-150 if that is the range?

danieljimeneznz commented 5 years ago

closing issue since there is a workaround.

k-okada commented 5 years ago

@danieljimeneznz what is the "workaround" ? from https://github.com/opencv/opencv/blob/master/modules/imgproc/src/hough.cpp#L174-L188, I think range 50-150 is not correct, it could be 1 to width*height.

hh129sss5 commented 2 years ago

Denied should money on this is only for overview and the other matter should be only 1

hh129sss5 commented 2 years ago

Denied should money on this is only for overview and the other matter should be only 1

Access denied