search

ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps
64 stars 70 forks source link

Add lk flow params trackbar #78

Closed taichiH closed 5 years ago

taichiH commented 5 years ago

Add track-bar to dynamically change parameters of goodFeaturesToTrack.

iory commented 5 years ago

Thank you for your contribution!

In this code, you inititialized value at first (https://github.com/ros-perception/opencv_apps/pull/78/files#diff-33f513cd81a102869702f7300479603bR325) . But, I think this initialization is not needed.

When we initialize dynamic reconfigure server, parameters are initialized by cfg's default parameters. https://github.com/ros/dynamic_reconfigure/blob/master/include/dynamic_reconfigure/server.h#L174-L193

After that, we call setCallback function. This function internally calls callback function (i.e reconfigureCallback function). https://github.com/ros/dynamic_reconfigure/blob/master/include/dynamic_reconfigure/server.h#L85

So, initialized values manually are not needed.

iory commented 5 years ago

@taichiH This PR's test failes and the test was fixed by following PR. https://github.com/ros-perception/opencv_apps/pull/79

Please rebase this PR.

iory commented 5 years ago

git pull --rebase origin indigo git push -f taichiH add_lk_flow_params_trackbar

taichiH commented 5 years ago

rebased @k-okada Travis passed. Please merge this.

k-okada commented 5 years ago

@taichiH please rebase origin/master to check on melodic and update http://wiki.ros.org/opencv_apps for new features.

k-okada commented 5 years ago

updated http://wiki.ros.org/opencv_apps#lk_flow and merged