search

ros-perception / opencv_apps

http://wiki.ros.org/opencv_apps
64 stars 70 forks source link

Debug view: Publish image instead opening OpenCV window #86

Closed fujimo-t closed 5 years ago

fujimo-t commented 5 years ago

Why does opencv_apps use OpenCV's window and not use ROS topic to output debug view?

I think using ROS topic better than OpenCV's window:

k-okada commented 5 years ago

if you run the node with debug_view:=false then you can run the node without OpenCV window.

https://github.com/ros-perception/opencv_apps/blob/indigo/launch/adding_images.launch#L8

fujimo-t commented 5 years ago

if you run the node with debug_view:=false then you can run the node without OpenCV window.

Yes, I know it.

What I want to say is not that the window is annoying. Just I think ROS topic is better than the window if we want to output debug information.

k-okada commented 5 years ago

what you can see on OpenCV window should be published as ros topic. https://github.com/ros-perception/opencv_apps/blob/indigo/src/nodelet/adding_images_nodelet.cpp#L221 and our test code also confirm that. https://github.com/ros-perception/opencv_apps/blob/indigo/src/nodelet/adding_images_nodelet.cpp#L221

◉ Kei Okada

2019年3月19日(火) 11:02 fujimo-t notifications@github.com:

if you run the node with debug_view:=false then you can run the node without OpenCV window. Yes, I know it.

What I want to say is not that the window is annoying. Just I think ROS topic is better than the window if we want to output debug information.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ros-perception/opencv_apps/issues/86#issuecomment-474168813, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3PMAiMiVbQvUcZ7w7xA6RwPxcm_Jks5vYEVLgaJpZM4b3aAM .

fujimo-t commented 5 years ago

I'm sorry for spending your time.

I somehow misunderstand that there aren't ros topic for debug output. This should be closed.